Re: [PATCH i-g-t] Make autogen.sh set the default format.subjectPrefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 07, 2017 at 04:54:53PM -0700, Eric Anholt wrote:
> CONTRIBUTING requests that people do this, but it's a lot easier if we
> just set it up by default for them.
> 
> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
> ---
> 
> I missed this step on my previous two patches, so let's just prevent
> that in the future.  :(
> 
>  autogen.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/autogen.sh b/autogen.sh
> index ec633f3efefd..53df7525a976 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -16,6 +16,9 @@ fi
>  autoreconf -v --install || exit 1
>  cd $ORIGDIR || exit $?
>  
> +git config --local --get format.subjectPrefix >/dev/null 2>&1 ||
> +    git config --local format.subjectPrefix "PATCH i-g-t"
> +

If your IGT is not in git, setting the config will output an error
message. Although autogen.sh is only in git, not in the dist tarball,
so that shouldn't be an issue.

Can you also document that autogen.sh does the config for you in
CONTRIBUTING?

Anyway,

Acked-by: Petri Latvala <petri.latvala@xxxxxxxxx>


>  if test -z "$NOCONFIGURE"; then
>          $srcdir/configure "$@"
>  fi
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux