Re: [PATCH 1/5] drm/i915/cfl: Introduce Coffee Lake platform definition.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




>-----Original Message-----
>From: Vivi, Rodrigo
>Sent: Tuesday, June 6, 2017 12:20 PM
>To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>Cc: Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; Srivatsa, Anusha
><anusha.srivatsa@xxxxxxxxx>
>Subject: [PATCH 1/5] drm/i915/cfl: Introduce Coffee Lake platform definition.
>
>Coffee Lake is a Intel® Processor containing Intel® HD Graphics following
>Kabylake.
>
>It is Gen9 graphics based platform on top of CNP PCH.
>
>Let's start by adding the platform definition based on previous platforms but yet
>as preliminary_hw_support.
>
>On following patches we will start adding PCI IDs and the platform specific
>changes.
>
>v2: Also add BS2 ring that is present on GT3. As on KBL, according
>    spec: "GT3 also has additional media blocks with second instance
>    of VEBox and VDBox each", i.e. BSD2 ring in our case. Noticed
>    when reviewing PCI ID patches.
>
>v3: CFL_PLATFORM instead for CFL_FEATURES because it contains
>    Platform information and no new features when compared to
>    BDW_FEATURES definition.
>
>Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

Reviewed-by: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>

> drivers/gpu/drm/i915/i915_drv.h          |  2 ++
> drivers/gpu/drm/i915/i915_pci.c          | 16 ++++++++++++++++
> drivers/gpu/drm/i915/intel_device_info.c |  1 +
> 3 files changed, 19 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>index c31c0cf..2f20e87 100644
>--- a/drivers/gpu/drm/i915/i915_drv.h
>+++ b/drivers/gpu/drm/i915/i915_drv.h
>@@ -826,6 +826,7 @@ enum intel_platform {
> 	INTEL_BROXTON,
> 	INTEL_KABYLAKE,
> 	INTEL_GEMINILAKE,
>+	INTEL_COFFEELAKE,
> 	INTEL_MAX_PLATFORMS
> };
>
>@@ -2768,6 +2769,7 @@ static inline struct scatterlist *__sg_next(struct
>scatterlist *sg)
> #define IS_BROXTON(dev_priv)	((dev_priv)->info.platform == INTEL_BROXTON)
> #define IS_KABYLAKE(dev_priv)	((dev_priv)->info.platform == INTEL_KABYLAKE)
> #define IS_GEMINILAKE(dev_priv)	((dev_priv)->info.platform ==
>INTEL_GEMINILAKE)
>+#define IS_COFFEELAKE(dev_priv)	((dev_priv)->info.platform ==
>INTEL_COFFEELAKE)
> #define IS_MOBILE(dev_priv)	((dev_priv)->info.is_mobile)
> #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> 				    (INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
>diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
>index f940e48..89f71e0 100644
>--- a/drivers/gpu/drm/i915/i915_pci.c
>+++ b/drivers/gpu/drm/i915/i915_pci.c
>@@ -425,6 +425,22 @@
> 	.ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING |
>BSD2_RING,  };
>
>+#define CFL_PLATFORM \
>+	.is_alpha_support = 1, \
>+	BDW_FEATURES, \
>+	.gen = 9, \
>+	.platform = INTEL_COFFEELAKE, \
>+	.ddb_size = 896
>+
>+static const struct intel_device_info intel_coffeelake_info = {
>+	CFL_PLATFORM,
>+};
>+
>+static const struct intel_device_info intel_coffeelake_gt3_info = {
>+	CFL_PLATFORM,
>+	.ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING |
>+BSD2_RING, };
>+
> /*
>  * Make sure any device matches here are from most specific to most
>  * general.  For example, since the Quanta match is based on the subsystem diff -
>-git a/drivers/gpu/drm/i915/intel_device_info.c
>b/drivers/gpu/drm/i915/intel_device_info.c
>index 3718341..acc746f 100644
>--- a/drivers/gpu/drm/i915/intel_device_info.c
>+++ b/drivers/gpu/drm/i915/intel_device_info.c
>@@ -51,6 +51,7 @@
> 	PLATFORM_NAME(BROXTON),
> 	PLATFORM_NAME(KABYLAKE),
> 	PLATFORM_NAME(GEMINILAKE),
>+	PLATFORM_NAME(COFFEELAKE),
> };
> #undef PLATFORM_NAME
>
>--
>1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux