Re: [PATCH] drm/i915/guc: Assert that we switch between known ggtt->invalidate functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On to, 2017-06-01 at 12:01 +0100, Chris Wilson wrote:
> On Thu, Jun 01, 2017 at 01:44:07PM +0300, Joonas Lahtinen wrote:
> > 
> > On to, 2017-06-01 at 10:04 +0100, Chris Wilson wrote:
> > > 
> > > When we enable the GuC, we enable an alternative mechanism for doing
> > > post-GGTT update invalidation. Likewise, when we disable the GuC, we
> > > restore the previous method. Assert that we change between known
> > > endpoints, so that we can catch if we accidentally clobber some other
> > > gen and if we change the invalidate routine without updating guc.
> > > 
> > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> > > Cc: Oscar Mateo <oscar.mateo@xxxxxxxxx>
> > > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
> > > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> > > Cc: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx>
> > > Cc: Michel Thierry <michel.thierry@xxxxxxxxx>
> > 
> > This was R-b'd by Michal already, a dup patch?
> 
> This is the second step to turn the v4.11 bugfix into a warning that it
> never happens again.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux