> -----Original Message----- > From: intel-gvt-dev [mailto:intel-gvt-dev-bounces@xxxxxxxxxxxxxxxxxxxxx] On > Behalf Of Chris Wilson > Sent: Friday, May 26, 2017 7:09 PM > To: Dong, Chuanxiao <chuanxiao.dong@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/3] drm/i915/gvt: Add gvt options sanitize > function > > On Fri, May 26, 2017 at 11:04:17AM +0800, Chuanxiao Dong wrote: > > The intel_gvt_sanitize_options will sanitize the GVT-g related options > > before doing GVT-g init. > > > > Suggested-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Signed-off-by: Chuanxiao Dong <chuanxiao.dong@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/i915_drv.c | 2 ++ > > drivers/gpu/drm/i915/intel_gvt.c | 36 > > ++++++++++++++++++++++++++---------- > > drivers/gpu/drm/i915/intel_gvt.h | 5 +++++ > > 3 files changed, 33 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > > b/drivers/gpu/drm/i915/i915_drv.c index 72fb47a..9c59b22 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -997,6 +997,8 @@ static void intel_sanitize_options(struct > drm_i915_private *dev_priv) > > DRM_DEBUG_DRIVER("use GPU semaphores? %s\n", > > yesno(i915.semaphores)); > > > > intel_uc_sanitize_options(dev_priv); > > + > > + intel_gvt_sanitize_options(dev_priv); > > } > > > > /** > > diff --git a/drivers/gpu/drm/i915/intel_gvt.c > > b/drivers/gpu/drm/i915/intel_gvt.c > > index e1ab643..dde9c78 100644 > > --- a/drivers/gpu/drm/i915/intel_gvt.c > > +++ b/drivers/gpu/drm/i915/intel_gvt.c > > @@ -51,6 +51,32 @@ static bool is_supported_device(struct > > drm_i915_private *dev_priv) } > > > > /** > > + * intel_gvt_sanitize_options - sanitize GVT related options > > + * @dev_priv: drm i915 private data > > + * > > + * This function is called at the i915 options sanitize stage. > > + */ > > +void intel_gvt_sanitize_options(struct drm_i915_private *dev_priv) { > > + if (!i915.enable_gvt) > > + return; > > + > > + if (intel_vgpu_active(dev_priv)) { > > + DRM_INFO("GVT-g is disabled for guest\n"); > > + goto bail; > > + } > > + > > + if (!is_supported_device(dev_priv)) { > > + DRM_INFO("Unsupported device. GVT-g is disabled\n"); > > + goto bail; > > + } > > Good. I came back to check that we didn't trigger an EIO if the device wasn't > supported (and only an EIO if the user gave conflicting params). > > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris > Thanks Chris. Patch 2/3 and 3/3 will be updated in v2 to use DRM_ERROR. Thanks Chuanxiao _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
