Re: [PATCH 3/3] drm/i915/guc: Remove last submission result from debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On to, 2017-05-18 at 11:31 +0000, Michal Wajdeczko wrote:
> Debugfs does not seems to be a right place to display transient data.
> If we want to capture errors, we should log them.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

<SNIP>

> @@ -2482,7 +2482,6 @@ static void i915_guc_client_info(struct seq_file *m,
>  		client->wq_size, client->wq_offset, client->wq_tail);
>  
>  	seq_printf(m, "\tWork queue full: %u\n", client->no_wq_space);

This seems like a valid candidate for removal too, the error will be
propagated (although, -EINVAL seems odd, -ENOSPC might make more
sense).

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux