Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > On Wed, May 17, 2017 at 03:41:49PM +0300, Mika Kuoppala wrote: >> The dma_buf_vmap in itself warns on error and then downgrades >> the return value from error ptr to NULL. Don't try to decode error >> value from the return in our test. >> > > Actually dma_buf_vmap shouldn't be WARNing here, so go fix that > instead. Regarless of warn, we have mixed use of null and errptr checks in the test. So eventually it might be best to return errptr from dma_buf_vmap along of fixing the WARN. But as discussed in irc, this might not bring much value. -Mika _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
