On Fri, May 12, 2017 at 02:17:29PM +0100, Chris Wilson wrote:
> The ABI for testing whether the device is wedged before use is
> gem_throttle(). This is encapsulated into igt_require_gem() and any test
> that depends upon execution on the GPU should be checking for GEM first.
>
> This test should just be igt_gem_require(drm_open_driver(DRIVER_INTEL));
Well, how do you expect people to spot your nifty tools and refactorings
if they don't show up on the m-l, don't get acks or reviews, and don't
come with api-docs? At least neither gmail nor google did find that patch
submitted anywhere.
Marta, can you pls review Chris' patch:
commit 9518cb59abe35143f15abac2b7ffdb99820ef53c
Author: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Date: Wed Feb 22 15:24:54 2017 +0000
igt: Start marking up GEM tests that require an alive GPU to function
Best would be to check that all gem tests really use this, and then also
add abi docs for this new helper.
Also, since we have igt_require_gem() already, what's the value of this
additional testcase? If we want to reboot machines if the gpu died, then
we need to have such a test at a higher level, in piglit. What we could do
is add a special exit code to igt that indicates a runtime problem (and
tells piglit to reboot), essentially PLEASE_REBOOT instead of SKIP (which
is what igt_require_gem() results in).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
