Re: [RFC] drm/i915: Allow the UMD to configure their own power clock state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On 05/10/2017 01:28 PM, Daniel Vetter wrote:
On Wed, May 10, 2017 at 2:59 PM, Joonas Lahtinen
<joonas.lahtinen@xxxxxxxxxxxxxxx> wrote:
@@ -841,6 +847,11 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
       if (ret)
               return ret;

+     /* Allow the UMD to configure their own power clock state */
+     ret = wa_ring_whitelist_reg(engine, GEN8_R_PWR_CLK_STATE);
+     if (ret)
+             return ret;
This is not a workaround, so it should be part of the cmd parser and
have an userspace.

cmd parser? This is Gen8+, so the cmd parser shouldn't even be active. Or am I missing something?

Yeah, the "This allows userspace ..." start of the commit message
should have been a dead giveaway that we do indeed need the userspace
patch for this too.
-Daniel

Yes, I got the memo :)
Dmitry has opened a ticket against intel-vaapi-driver (https://github.com/01org/intel-vaapi-driver/issues/152) so hopefully we will have a userspace soon.

-- Oscar
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux