On Wed, Apr 26, 2017 at 03:36:16PM -0300, Paulo Zanoni wrote: > > I have a feeling I asked this before, but why aren't we just fixing > > the kernel to report it correctly? For any platform with FBC2 it > > should be trivial, > > Right, I see there's a reg for that for ILK/SNB. > > > for FBC1 slightly more complicate as you probably > > have to check each individual tag. > > I didn't check the docs for that. > > Maybe we should change the comment from "early generations are not able > to report compression status" to something more accurate like "the > Kernel doesn't report compression status for early generations". > > > There are quite a few different ways to solve the problem involved in > this patch, and some of the would remove the need to check for platform > generations in the user space side. An example alternative would be to > always print "Compressing: " and then put "no" when FBC is disabled and > "unknown" for platforms where we don't know what to print. In fact it's > still on my TODO list to add a ton more information to i915_fbc_status, > but I'm not going to work on that soon. And there's always the problem > with having to sync Kernel and IGT. > > Anyway, the current patch plugs the current hole, so I think further > improvements to this area can come on top of it: > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > Pushed this patch, thanks. -- Petri Latvala _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
