On Tue, 18 Apr 2017, Puthikorn Voravootivat <puthik@xxxxxxxxxxxx> wrote: > Some panel will default to zero brightness when turning the > panel off and on again. This patch stores last brightness level > before turning off and set them back when panel is turning on. > > Signed-off-by: Puthikorn Voravootivat <puthik@xxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c > index ae1b6fe67feb..f99cf0a6ae44 100644 > --- a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c > @@ -95,6 +95,7 @@ intel_dp_aux_set_backlight(struct intel_connector *connector, u32 level) > DRM_DEBUG_KMS("Failed to write aux backlight level\n"); > return; > } > + connector->panel.backlight.level = level; This gets already done in intel_panel_set_backlight(), and you shouldn't touch it here. > } > > /* > @@ -150,6 +151,7 @@ static void intel_dp_aux_enable_backlight(struct intel_connector *connector) > drm_dp_dpcd_writeb(&intel_dp->aux, > DP_EDP_BACKLIGHT_MODE_SET_REGISTER, new_dpcd_buf); > } > + intel_dp_aux_set_backlight(connector, connector->panel.backlight.level); Seems like a sensible change. BR, Jani. > } > > static void intel_dp_aux_disable_backlight(struct intel_connector *connector) -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx