Re: [PATCH v7 13/20] drm/i915/guc: Rename the function that resets the GuC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/04/17 00:40, Tvrtko Ursulin wrote:
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -46,9 +46,9 @@ static int __intel_uc_reset_hw(struct
drm_i915_private *dev_priv)
     int ret;
     u32 guc_status;

-    ret = intel_guc_reset(dev_priv);
+    ret = intel_reset_guc(dev_priv);
     if (ret) {
-        DRM_ERROR("GuC reset failed, ret = %d\n", ret);
+        DRM_ERROR("Reset GuC failed, ret = %d\n", ret);

As a non-native speaker I might be wrong, but was thinking something
like "Failed to reset GuC", "Resetting GuC failed", "Reset of GuC
failed" would be clearer? I leave it for someone more competent to decide.

"Failed to reset GuC" sounds good to me.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux