On Mon, Nov 14, 2011 at 21:22, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > Add new ioctls for getting and setting the current destination color > key. ?This allows for simple overlay display control by matching a color > key value in the primary plane before blending the overlay on top. > > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org> Just a few comments because reviewing patches here is a royal pain: - Is taking dev->struct_mutex really required around the register access? - You unconditionally enable the color key. Do we anticipate any other uses (like no color key or dst color key) or is this just the make-Xv-work ioctl? - Same for the mask .... Cheers, Daniel -- Daniel Vetter daniel.vetter at ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch
