Re: [i-g-t PATCH v4 1/2] lib/igt_kms: Add support for 4K and audio HDMI EDID injection.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Some minor nitpicks on the series:

lib/tests/.gitignore:
 You need to add igt_hdmi_inject here. Only
 tests/ has automatic .gitignore generation.

tests/Makefile.sources:
 You added kms_hdmi_inject to TESTS_progs, it should go to
 TESTS_progs_M as it contains subtests. The difference is absolutely
 zero though, both sets get handled in the exact same way, and the
 different listings will go away as soon as I can clean up the build
 system some more, but meanwhile... *shrug*


The only Intel-specific part I can spot is that one chunk where you
check for at-least-hsw. Is that so you can properly report skip
instead of fail? It would be good to make this all suitable for
non-Intel hw.


Anyway, series is

Reviewed-by: Petri Latvala <petri.latvala@xxxxxxxxx>



_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux