On to, 2017-04-06 at 17:18 -0700, Daniele Ceraolo Spurio wrote: > The wopcm registers are write-once, so any write after the first one > will just be ignored. The registers survive a GPU reset but not > always a suspend/resume cycle, so to keep things simple keep the > writes in the intel_uc_init_hw function instead of moving it earlier > to make sure we attempt them every time we try to load GuC. > > Cc: Jeff McGee <jeff.mcgee@xxxxxxxxx> > Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx> > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> This is an improvement, so: Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> To be exact, shouldn't we read the value and see if it has been written previously (bit 1). i915 module can be removed and added multiple times. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
