On Mon, Apr 10, 2017 at 01:37:01PM +0100, Chris Wilson wrote: > On Mon, Apr 10, 2017 at 01:54:45PM +0200, Daniel Vetter wrote: > > Yet again I've proven that I can't negate conditions :( > > > > Fixes: eb8eb02ed850 ("drm: Drop modeset_lock_all from the getproperty ioctl") > > You also get to write the igt/kms_getproperty, starting with a > memset(prop_values, 0xc5, foo); > drmIoctl(GETPROPERTY); > igt_assert(!memchr(prop_values, 0xc5, bar)); Testcase: igt/kms_properties/get_property-sanity Thanks for reminding me to not be lazy with testing stuff we've broken! Pushed the patch to -next-fixes. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx