On Mon, Apr 10, 2017 at 04:34:30PM +0300, Ville Syrjälä wrote: > On Mon, Apr 10, 2017 at 01:56:31PM +0100, Chris Wilson wrote: > > On Mon, Apr 10, 2017 at 12:41:30PM +0100, Chris Wilson wrote: > > > On Mon, Apr 10, 2017 at 10:22:00AM +0000, Michal Wajdeczko wrote: > > > > There is no need to use macros as we can use generic function. > > > > And we can save ~2000 bytes in driver footprint. > > > > > > > > v2: drop ret var, add 10ms fallback (Chris) > > > > > > > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > > > > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > > > Hmm, forgot the convesion from I915_READ to I915_READ_FW. That should be > > safe here as this gen doesn't have the concurrent cacheline issue, iirc? > > Isn't HSW exactly the platform where it happens very easily? I thought lpt was later, or rather I just assume that any codename I don't recognise is postmodern. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
