Re: [PATCH 3/5] drm/i915: Generate the engine name based on the instance number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 07, 2017 at 06:23:14PM +0200, Michal Wajdeczko wrote:
> On Fri, Apr 07, 2017 at 02:15:47AM -0700, Oscar Mateo wrote:
> > Not really needed, but makes the next change a little bit more compact.
> > 
> > v2:
> >   - Use zero-based numbering for engine names: xcs0, xcs1.. xcsN (Tvrtko, Chris)
> >   - Make sure the mock engine name is null-terminated (Tvrtko, Chris)
> > 
> > v3: Because I'm stupid (Chris)
> > 
> > v4: Verify engine name wasn't truncated (Michal)
> > 
> > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> > Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx>
> > ---
> 
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>

s/WARN_ON/GEM_WARN_ON/ ?

The WARN_ON in mock_engine.c is off-by-one, but really we don't care too
much there so just kill that warn.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux