On Thu, Apr 6, 2017 at 6:51 PM, Eric Anholt <eric@xxxxxxxxxx> wrote: > Daniel Vetter <daniel.vetter@xxxxxxxx> writes: >> Atomic helpers really want this instead of the hacked-up legacy >> backoff trick, which unfortunately prevents drivers from using their >> own private drm_modeset_locks. >> >> Aside: There's a few atomic drivers (nv50, vc4, soon vmwgfx) which >> don't yet use the new atomic color mgmt/gamma table stuff. Would be >> nice if they could switch over and just hook up >> drm_atomic_helper_legacy_gamma_set() instead. > > For notes like this, it would be helpful to have a pointer to a driver > doing it cleanly the current way. Yeah, good point. And the kernel-doc for legacy_gamma_set is also not all that awesome. So we currently have i915, mediatek and omapdrm using this, and for the new atomic gamma stuff we do have fairly reasonable docs (just a bit harder to find that I thought they'd be): https://dri.freedesktop.org/docs/drm/gpu/drm-kms.html#color-management-properties I'll try and type up a patch to sprinkle a few more hints around and connect the pieces. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
