On Thu, Mar 30, 2017 at 05:58:07PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
>
> It is hard to imagine a more basic test than this one.
>
> Also removed the skip on simulation since I don't know why
> would that be needed here.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> ---
> tests/gem_create.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/gem_create.c b/tests/gem_create.c
> index de7b82094545..f687b7b40be4 100644
> --- a/tests/gem_create.c
> +++ b/tests/gem_create.c
> @@ -44,6 +44,7 @@
> #include <sys/stat.h>
> #include <sys/time.h>
> #include <getopt.h>
> +#include <limits.h>
>
> #include <drm.h>
>
> @@ -95,10 +96,13 @@ static void invalid_flag_test(int fd)
>
> static void invalid_size_test(int fd)
> {
> - int handle;
> + uint32_t handle;
>
> handle = __gem_create(fd, 0);
> igt_assert(!handle);
> +
> + handle = __gem_create(fd, INT_MAX * 4096UL + 1);
Why is that an invalid size? Invalid huge in terms of API might arguably
be 1<<virtual_bits + 1, but otherwise our only limitation is that it
has to be >0 and page aligned.
/* Only multiples of page size (4096) are allowed. Check all likely
* misalignments from pot boundaries to check validity and possibility
* of incorrect overflow.
*/
for (int order = 0; order < 64; order++) {
uint64_t size = (uint64_t)1 << order;
igt_assert(!__gem_create(fd, size - 1));
igt_assert(!__gem_create(fd, size + 1));
if (order < 12)
igt_assert(!__gem_create(fd, size + 1));
}
Still enshrines knowlege of PAGE_SIZE into the ABI. Meh.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
