On Tue, Mar 28, 2017 at 10:27:28AM +0200, Michal Wajdeczko wrote:
> On Tue, Mar 28, 2017 at 10:05:31AM +0300, Joonas Lahtinen wrote:
> > On ma, 2017-03-27 at 17:19 +0000, Michal Wajdeczko wrote:
> > > The file fits better. Also use "<invalid>" for invalid case.
> > >
> > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> > > Cc: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> >
> > <SNIP>
> >
> > > @@ -26,6 +26,24 @@
> > > #include "intel_uc.h"
> > > #include <linux/firmware.h>
> > >
> > > +
> > > +/* User-friendly representation of an enum */
> > > +const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status)
> >
> > This could be static inline in the .h too.
> >
> > > +{
> > > + switch (status) {
> > > + case INTEL_UC_FIRMWARE_FAIL:
> > > + return "FAIL";
> > > + case INTEL_UC_FIRMWARE_NONE:
> > > + return "NONE";
> > > + case INTEL_UC_FIRMWARE_PENDING:
> > > + return "PENDING";
> > > + case INTEL_UC_FIRMWARE_SUCCESS:
> > > + return "SUCCESS";
> > > + default:
> >
> > Add MISSING_CASE(status); here.
>
> This will require another patch that will move definition of
> MISSING_CASE macro from i915_drv.h to i915_utils.h as intel_uc.h
> is included now ahead of MISSING_CASE definition... stay tuned ;)
>
There is also other option: we can drop "default" case and then
rely on the compiler to complain at build time when we miss any enum.
-Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
