On pe, 2017-03-24 at 09:49 +0800, Chuanxiao Dong wrote:
> GVT request needs a manual mmio load/restore. Before GuC submit
> a request, send notification to gvt for mmio loading. And after
> the GuC finished this GVT request, notify gvt again for mmio
> restore. This follows the usage when using execlists submission.
>
> v2: use context_status_change instead of execlists_context_status_change
> for better understanding (ZhengXiao)
> v3: remove the comment as it is obvious and not friendly to
> the caller (Kevin)
> v4: fix indent issues (Joonas)
> rename the context_status_change to intel_gvt_notify_context_status (Chris)
>
> Cc: xiao.zheng@xxxxxxxxx
> Cc: kevin.tian@xxxxxxxxx
> Cc: joonas.lahtinen@xxxxxxxxxxxxxxx
> Cc: chris@xxxxxxxxxxxxxxxxxx
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@xxxxxxxxx>
<SNIP>
> @@ -634,6 +636,8 @@ static void i915_guc_irq_handler(unsigned long data)
> rq = port[0].request;
> while (rq && i915_gem_request_completed(rq)) {
> trace_i915_gem_request_out(rq);
> + intel_gvt_notify_context_status(rq,
> + INTEL_CONTEXT_SCHEDULE_OUT);
Code indent is still broken.
> @@ -87,5 +87,19 @@ uint64_t intel_lr_context_descriptor(struct i915_gem_context *ctx,
> /* Execlists */
> int intel_sanitize_enable_execlists(struct drm_i915_private *dev_priv,
> int enable_execlists);
> +static inline void
> +intel_gvt_notify_context_status(struct drm_i915_gem_request *rq,
> + unsigned long status)
With that prefix, this needs to go to intel_gvt.h, where you can take
advantage of the existing #ifdef block (which should really be #if
IS_ENABLED() too).
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
