On 21/03/17 18:41, Daniel Vetter wrote: > The trouble here is that it does multiple atomic commits under one > drm_modeset_lock_all, which breaks the behind-the-scenes acquire > context magic that function pulls off. It's much better to have one > overall atomic commit. That we still have multiple atomic commits > prevents us from adding some pretty useful debug checks to the atomic > machinery. > > Hence it is really a bad idea to call the legacy > drm_crtc_force_disable_all() function. There's 2 atomic drivers using > this still, nouveau and tinydrm. To fix this, introduce a new > drm_atomic_helper_shutdown() by extracting the code from i915. > > While at it improve kernel-doc and catch future offenders by > sprinkling a WARN_ON into the legacy function. We should probably move > those into the legacy modeset helpers, too ... > > v2: Make it compile on arm drivers too (Noralf). > > v3: Correct kerneldoc to point at _disable_all(). > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Acked-by: Noralf Trønnes <noralf@xxxxxxxxxxx> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Cc: Noralf Trønnes <noralf@xxxxxxxxxxx> > Cc: Ben Skeggs <bskeggs@xxxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> Tested-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> As a side note, I find it a bit odd that when fbdev is disabled, the crtcs stays enabled even when DRM userspace app quits. Or is that just omapdrm behavior? I presume not, as this shutdown on unload would not be needed otherwise. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
