Re: [dim PATCH 3/7] dim: add 'make mancheck' target to check all subcommands have been documented

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 24, 2017 at 06:11:55PM +0200, Jani Nikula wrote:
> Just a simple grep.
> 
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
>  Makefile | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index c1fe02c1b565..ce283114c4aa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -32,6 +32,13 @@ SC_EXCLUDE := \
>  shellcheck:
>  	shellcheck $(SC_EXCLUDE) dim bash_completion
>  
> +mancheck:
> +	@for cmd in $$(dim list-commands); do \
> +		if ! grep -q "^$$cmd" dim.rst; then \
> +			echo "$$cmd not documented"; \
> +		fi \
> +	done
> +

Please add

check: mancheck shellcheck all

or whatever the Makefile magic for this is. I don't want to remember
running piles of commands before pushing/sending out some dim patches :-)

With that, acked.
-Daniel

>  clean:
>  	rm -f drm-intel.html drm-intel-flow.svg dim.html drm-misc.html
>  
> -- 
> 2.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux