It's a good practice to use "git am" to apply the original patch and then "git commit --amend" to it, so that the "From: " field stays intact. Or use git commit --amend --author="John Doe <foo@xxxxxxx>" but that is more prone to typos. On ti, 2017-03-21 at 02:02 -0700, Oscar Mateo wrote: > Started adding proper teardown to guc_client_alloc, ended up removing > quite a few dead ends where errors communicating with the GuC were > silently ignored. There also seemed to be quite a few erronous > teardown actions performed in case of an error (ordering wrong). > > v2: > - Increase function symmetry/proximity (Michal/Daniele) > - Fix __reserve_doorbell accounting for high priority (Daniele) > - Call __update_doorbell_desc! (Daniele) > - Isolate __guc_{,de}allocate_doorbell (Michal/Daniele) > > v3: > - "Select" a cacheline is a more accurate verb than "reserve" (Daniele). > - We cannot update & create the doorbell without reserving it first, so > move the whole doorbell creation for execbuf_client to the submission > enable (Oscar).i > - Add a fixme for ignoring possible doorbell destroy errors. > > v4: > - Remove comment about is_high_priority (Daniele) > - Debug message typo (Daniele) > - Reuse __get_doorbell in more places (Daniele) > - Do not do arithmetic on void pointers (Daniele) > - Add comment to __reset_doorbell (Daniele) > > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx> The R-b should probably be after S-o-b if it was to last version. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx