On 3/21/2017 2:02 AM, Oscar Mateo wrote:
It's mandatory and it gets created if and only if GuC submission is enabled, so that should be the condition for informing the GuC about it.
This is true now, but GuC might actually require the ADS even if GuC submission is disabled, depending on the features being used. In the future we might therefore want to gate ADS logic based on the value of guc_loading instead of guc_submission.
This change is coherent with the current flow and makes things cleaner, so: Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
Also s/guc_addon_create/guc_ads_create and s/guc_addon_destroy/guc_ads_destroy and, while at it, add an explanation of what things go inside the ADS object. Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx>
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
