Re: [PATCH 08/15] drm/i915: Pass vma to relocate entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On to, 2017-03-16 at 13:19 +0000, Chris Wilson wrote:
> We can simplify our tracking of pending writes in an execbuf to the
> single bit in the vma->exec_entry->flags, but that requires the
> relocation function knowing the object's vma. Pass it along.
> 

Drop a comment here that the flushing granularity is "any bit set"
level, so extra tracking granularity isn't helping.

> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

<SNIP>

After this, pending_read_domains / pending_write_domain are unused in
DRM scope, so could be removed.

> @@ -1669,7 +1652,7 @@ i915_gem_do_execbuffer(struct drm_device *dev,
>  	}
>  
>  	/* Set the pending read domains for the batch buffer to COMMAND */

Nuke this comment too.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux