[PATCH 6/8] dim: pipe dim_cite output directly instead of using echo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fix shellcheck SC2005: Useless echo? Instead of 'echo $(cmd)', just use
'cmd'.

Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
---
 Makefile | 1 -
 dim      | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 89b381c1e0aa..fe7e44ad69d9 100644
--- a/Makefile
+++ b/Makefile
@@ -21,7 +21,6 @@ dim.html: dim.rst
 
 SC_EXCLUDE := \
 	-e SC2001 \
-	-e SC2005 \
 	-e SC2034 \
 	-e SC2046 \
 	-e SC2086 \
diff --git a/dim b/dim
index 8bbff67b3f80..16e489c0b508 100755
--- a/dim
+++ b/dim
@@ -858,7 +858,7 @@ function dim_cherry_pick_branch
 		commit_list_references $commit
 		if ! git cherry-pick -x -s $commit; then
 			echo "FAILED: $(dim_cite $commit)"
-			echo "$(dim_cite $commit)" >> $fail_log
+			dim_cite $commit >> $fail_log
 			git cherry-pick --abort
 		fi
 	done
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux