On Fri, Mar 17, 2017 at 12:42:51PM +0200, Jani Nikula wrote:
> Noticing that 64a54c5e1a5d ("dim: Add add-link command") added a
> condition that is always true (if [ -n $foo ]), despite my review of the
> patch, I refreshed some of my old patches to fix issues that can be
> caught by shellcheck.
>
> Starting from patch 1, the minimal merge criteria for any new dim
> patches is that 'make shellcheck' passes.
>
> I add shellcheck exceptions for starters, so there are no errors
> reported, and then remove the exceptions by fixing them one by one. I'm
> not sure if we'll ever fix them all, but let's at least make sure we're
> not adding any new silly mistakes.
Ack on the entire series. checkpatch for dim!
-Daniel
>
> BR,
> Jani.
>
>
>
> Jani Nikula (10):
> dim: add make target to shellcheck dim
> dim: quote check for non-zero string
> dim: replace expr with $((..))
> dim: use $* instead of $@ within string
> dim: double quote array expansions
> dim: quote expressions using { }
> dim: add double quotes to prevent glob interpretation
> dim: prevent * from becoming options
> dim: avoid useless cat in apply-branch
> dim: Replace `..` with $(..)
>
> Makefile | 16 +++++++
> dim | 143 ++++++++++++++++++++++++++++++++-------------------------------
> 2 files changed, 88 insertions(+), 71 deletions(-)
>
> --
> 2.1.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
