Fix shellcheck SC2070: Always true because you failed to quote. Use [[ ]] instead. Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> --- Makefile | 1 - dim | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 96aed8581f9f..a3a1c8dba3ed 100644 --- a/Makefile +++ b/Makefile @@ -31,7 +31,6 @@ SC_EXCLUDE := \ -e SC2046 \ -e SC2053 \ -e SC2068 \ - -e SC2070 \ -e SC2086 \ -e SC2089 \ -e SC2090 \ diff --git a/dim b/dim index 64edcda83084..964dfcb655cb 100755 --- a/dim +++ b/dim @@ -704,7 +704,7 @@ function dim_add_link rm -f $file - if [ -n $message_id ]; then + if [[ -n "$message_id" ]]; then dim_commit_add_tag "Link: http://patchwork.freedesktop.org/patch/msgid/$message_id"; else echoerr "No message-id found in the patch file." -- 2.1.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
