On Mon, Mar 13, 2017 at 02:15:34PM +0000, Chris Wilson wrote: > On Mon, Mar 13, 2017 at 01:02:04PM +0200, Petri Latvala wrote: > > On Mon, Mar 13, 2017 at 10:50:04AM +0000, Chris Wilson wrote: > > > Still completely lacking justification. The above is a non sequitur; > > > static testlist generation can be done just from the source. > > > > Static testlist generation can be done and it breaks when run on a > > kernel without selftests enabled. > > That doesn't make sense. static is a static list, as simple as using sed > on the headers. Without this series, having the selftests in a .testlist with piglit results in KeyError: 'igt@drv_selftest@mock_sanitycheck' et al. "But we can fix piglit to ignore that error!" Sure, and that's on the way, but we're not there yet. Then when we add testlist checking to IGT to notify developers that the test they removed/renamed was in a testlist file and the testlist should be edited, we also hardcode drm_mm, drv_selftest and $whatever-is-in-future to not be checked? When generating documentation, we ignore that the docs for drm_mm and drv_selftest generate different documents depending on where they are built? We also hardcode igt_command_line.sh to ignore errors with drm_mm and drv_selftest? Or, just maybe, we could follow the convention of having subtest enumeration always work regardless of environment, by always exposing certain test names? Why the rules don't apply to kselftest launchers? -- Petri Latvala _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
