On Fri, 10 Mar 2017, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Mar 10, 2017 at 03:27:57PM +0200, Jani Nikula wrote:
>> We don't use the error return for anything other than reporting and
>> logging that there is no VBT. We can pull the logging in the function,
>> and remove the error status return. Moreover, if we needed the
>> information for something later on, we'd probably be better off storing
>> the bit in dev_priv, and using it where it's needed, instead of using
>> the error return.
>>
>> While at it, improve the comments.
>>
>> Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx>
>> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>> ---
>> drivers/gpu/drm/i915/i915_drv.c | 4 +---
>> drivers/gpu/drm/i915/i915_drv.h | 2 +-
>> drivers/gpu/drm/i915/intel_bios.c | 31 ++++++++++++++++---------------
>> 3 files changed, 18 insertions(+), 19 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index b1e9027a4f80..1af54717fa81 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -567,9 +567,7 @@ static int i915_load_modeset_init(struct drm_device *dev)
>> if (i915_inject_load_failure())
>> return -ENODEV;
>>
>> - ret = intel_bios_init(dev_priv);
>> - if (ret)
>> - DRM_INFO("failed to find VBIOS tables\n");
>> + intel_bios_init(dev_priv);
>
> Sold.
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Pushed patch 1, thanks for the review.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
