> -----Original Message----- > From: Jani Nikula [mailto:jani.nikula@xxxxxxxxxxxxxxx] > Sent: Thursday, March 9, 2017 9:48 PM > To: Chris Wilson; Dong, Chuanxiao > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] drm/i915/gvt: add enable_execlists check > before enable gvt > > On Thu, 09 Mar 2017, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Mar 09, 2017 at 01:03:17PM +0000, Dong, Chuanxiao wrote: > >> The message printed is longer than 80 characters, and checkpatch tool > also complain with " quoted string split across lines" by splitting to multiple > lines. So should I use the message print like below? > >> > >> DRM_INFO("GPU guest virtualisation [GVT-g] disabled due to "); > >> DRM_INFO("disabled execlist submission "); > >> DRM_INFO("[i915.enable_execlists module parameter]\n"); > >> > >> Or any better idea? > > > > Just ignore checkpatch. Either split the line or not, that's up to you > > :) > > Btw ignoring checkpatch is not general advise. Please do always look at > checkpatch results, it does give helpful feedback on silly mistakes. But just > don't regard it as the final authority on kernel style, use your own discretion. > In this case, checkpatch is just silly. I see. Thanks Chris and Jani for the guide. :) Will send out the v2 with the suggested message. Thanks Chuanxiao > > > BR, > Jani. > > > -- > Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
