Re: [PATCH 2/2] drm/i915/huc: Demote fw load to notice log level

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 08, 2017 at 04:33:11PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> Error is probably too high since it is an optional feature so
> it is better not to create too much commotion and especially
> cause BAT runs to log errors if firmware is not present.

I've seen confused users asking about HuC. It's a good idea IMO.

Reviewed-by: Michał Winiarski <michal.winiarski@xxxxxxxxx>

-Michał
 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
> Cc: Michał Winiarski <michal.winiarski@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/intel_huc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_huc.c b/drivers/gpu/drm/i915/intel_huc.c
> index 8cf104350e5b..8817d404c616 100644
> --- a/drivers/gpu/drm/i915/intel_huc.c
> +++ b/drivers/gpu/drm/i915/intel_huc.c
> @@ -262,7 +262,7 @@ int intel_huc_load(struct drm_i915_private *dev_priv)
>  	if (huc_fw->load_status == INTEL_UC_FIRMWARE_PENDING)
>  		huc_fw->load_status = INTEL_UC_FIRMWARE_FAIL;
>  
> -	DRM_ERROR("Failed to complete HuC uCode load with ret %d\n", err);
> +	DRM_NOTE("Failed to complete HuC uCode load with ret %d\n", err);
>  
>  	return err;
>  }
> -- 
> 2.9.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux