On Wed, Mar 08, 2017 at 02:19:48AM +0100, Srivatsa, Anusha wrote: > > > >-----Original Message----- > >From: Intel-gfx [mailto:intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of > >Arkadiusz Hiler > >Sent: Tuesday, March 7, 2017 7:25 AM > >To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > >Subject: [PATCH 10/10] drm/i915/uc: Add params for specifying > >firmware > > > >`guc_firmware_path` and `huc_firmware_path` module parameters are added. > > > >Using the parameter disables version checks and loads desired firmware instead > >of the default one. > > I see that the effort of this patch makes us test with different > firmware versions and not just the default one. But is it worth > introducing two new params ? We already have 3 parameters that are guc > and huc related. > > Anusha Hey, Having a mean to easily point to any binary you want to try out helps with testing and verification, without the need to do in-kernel changes. This param was suggested by Chris, and I've seen couple of similar patches by different people in their trees - I've used one myself. Since it seem so common, why not have it in the mainline? It's _unsafe anyway. -- Cheers, Arek _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
