Op 01-03-17 om 10:52 schreef Daniel Vetter: > The trouble here is that looking at all connector->state in the > verifier isn't good, because that's run from the commit work, which > doesn't hold the connection_mutex. Which means we're only allowed to > look at states in our atomic update. > > The simple fix for future proofing would be to switch over to > drm_for_each_connector_in_state, but that has the problem that the > verification then fails if not all connectors are in the state. And we > also need to be careful to check both old and new encoders, and not > screw things up when an encoder gets reassigned. > > Note that this isn't the full fix, since we still look at > connector->state. To fix that, we need Maarten's patch series to > switch over to state pointers within drm_atomic_state, but that's a > different series. > > v2: Use oldnew iterator (Maarten). > > v3: Rebase onto the iter_get/put->iter_begin/end rename. > > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
