If during VBT parsing we find that the port is unused,
the driver code just bails out without clearing the
defaults for that port. This can cause failures down
the path through link training for unused Port.
This patch fixes this issue by clearing the defaults
before bailing out from the VBT parsing function.
v2:
Set the values to false instead of 0 (Ville)
Reviewed-by: Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx>
Cc: Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx>
Signed-off-by: Manasi Navare <manasi.d.navare@xxxxxxxxx>
---
drivers/gpu/drm/i915/intel_bios.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index e144f03..416d597 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1148,9 +1148,15 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, enum port port,
}
}
}
- if (!child)
- return;
+ if (!child) {
+ /* Clear the DDI VBT Port info values */
+ info->supports_dvi = false;
+ info->supports_hdmi = false;
+ info->supports_dp = false;
+ info->supports_edp = false;
+ return;
+ }
aux_channel = child->common.aux_channel;
ddc_pin = child->common.ddc_pin;
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
