On 03/01/2017 04:37 AM, Joonas Lahtinen wrote:
On pe, 2017-02-24 at 06:01 -0800, Oscar Mateo wrote:
When initializing the GuC log struct, there is an object we need to
allocate always, since the GuC needs its address at fw load time.
The rest are "extras", in the sense that we only need them if we
actually enable GuC logging. Make that distinction explicit by
subdividing further the intel_guc_log struct.
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx>
I'm not sure about calling them extras. How about runtime?
Agree, runtime sounds much better. I'll refresh the patch.
Also, I'm not quite sure if the abstractions are currently correct
(despite the names), logging seems to control overall guc interrups,
for example (i915_guc_log_unregister func).
Hmmm... GuC interrupts are a mess, I agree (for the moment the only
Guc2Host interrupts we handle are log-related ones, so I imagine that's
the reason, but this could very easily change in the future). I'll try
to fix this either as part of patch 3 or in a separate patch.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
