On 2 March 2017 at 14:46, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > On Thu, Mar 02, 2017 at 02:39:16PM +0100, Tomeu Vizoso wrote: >> On 2 March 2017 at 11:12, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: >> > On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tomeu Vizoso wrote: >> >> Instead of checking for "i915_error_state" within dri/N/, check for >> >> "name". >> >> >> >> This allows more tests to run against drivers other than i915. >> > >> > Bleh. Sadly many users are expecting to have the i915 directory. Please >> > kill the singleton and convert users to request which device debugfs >> > they want. >> >> Are you sure this is needed? If a test opened the device with >> DRIVER_INTEL, it cannot happen that the debugfs dir is present but the >> i915-specific files aren't. > > Opening by DRIVER_INTEL does not mean that the first name is i915. I am > suggesting that we transition away from assuming that we only want to > open i915's debugfs by opening the exact debugfs dir. (i.e. find the > minor index for the desired device, then open that path.) Got it now, thanks for the explanation. Regards, Tomeu > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
