On Fri, Feb 24, 2017 at 11:05:30AM -0800, Michel Thierry wrote: > HuC depends on GuC, so be it. > > Suggested-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Signed-off-by: Michel Thierry <michel.thierry@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/i915_gpu_error.c | 11 +++++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index a331c00523bc..1f949cc4a072 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -958,6 +958,8 @@ struct i915_gpu_state { > u32 dmc_version; > u32 guc_loaded; > u32 guc_version; > + u32 huc_loaded; > + u32 huc_version; I'll just ask once if you might consider merging major_ver_found, minor_ver_found in fw so we don't dance around u16 -> u32 -> u16 so blatantly. Patches do what they say, so Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Just beware the style police. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx