On Fri, Feb 24, 2017 at 04:39:58PM +0100, Arkadiusz Hiler wrote:
> The file fits better.
>
> Additionally rename it to intel_uc_prepare_fw(), as the function does
> more than simple fetch.
Hmm, new function does not contain "fetch" verb and "prepare" alone is
not much meaningful
>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx>
> ---
<snip>
> diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h
> index 41b7351..e411629 100644
> --- a/drivers/gpu/drm/i915/intel_uc.h
> +++ b/drivers/gpu/drm/i915/intel_uc.h
> @@ -187,16 +187,18 @@ struct intel_huc {
> void intel_uc_init_early(struct drm_i915_private *dev_priv);
> int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 len);
> int intel_guc_sample_forcewake(struct intel_guc *guc);
> +void intel_uc_prepare_fw(struct drm_i915_private *dev_priv,
> + struct intel_uc_fw *uc_fw);
Can you keep "intel_uc_" function declarations together?
>
> /* intel_guc_loader.c */
> void intel_guc_init(struct drm_i915_private *dev_priv);
> int intel_guc_init_hw(struct drm_i915_private *dev_priv);
> void intel_guc_fini(struct drm_i915_private *dev_priv);
> const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status);
> +void intel_uc_prepare_fw(struct drm_i915_private *dev_priv,
> + struct intel_uc_fw *uc_fw);
This one is redundant ;)
-Michal
> int intel_guc_suspend(struct drm_i915_private *dev_priv);
> int intel_guc_resume(struct drm_i915_private *dev_priv);
> -void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
> - struct intel_uc_fw *uc_fw);
> u32 intel_guc_wopcm_size(struct drm_i915_private *dev_priv);
>
> /* i915_guc_submission.c */
> --
> 2.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
