Re: [PATCH v2 11/15] drm/i915: Exercise request cancellation using a mock selftest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 22, 2017 at 01:59:13PM +0000, Chris Wilson wrote:
> On Wed, Feb 22, 2017 at 01:46:10PM +0000, Tvrtko Ursulin wrote:
> > 
> > On 22/02/2017 11:46, Chris Wilson wrote:
> > >+	ctx[1] = mock_context(i915, "B");
> > >+	vip = mock_request(i915->engine[RCS], ctx[1], 0);
> > >+	if (!vip) {
> > >+		err = -ENOMEM;
> > >+		goto err_locked;
> > 
> > Leaks the request.
> 
> That's been handed over to the device.

However, we shouldn't assume that the test harness is functioning
perfectly and the request remains valid as we poke it without a
reference of our own.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux