Re: [PATCH] drm/i915: Add i915_param charp macro magic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 22, 2017 at 12:30:38PM +0200, Jani Nikula wrote:
> On Wed, 22 Feb 2017, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, Feb 22, 2017 at 12:06:35PM +0200, Jani Nikula wrote:
> >> On Tue, 21 Feb 2017, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> >> > Handling the dynamic charp module parameter requires us to copy it for
> >> > the error state, or remember to lock it when reading (in case it used
> >> > with 0600).
> >> >
> >> > v2: Use __always_inline and __builtin_strcmp
> >> >
> >> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> >> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> >> 
> >> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> >
> > Joonas, do we feel justified in pushing now that Jani has a pending
> > usecase?
> 
> And how about those firmware blob overrides, you had a patch for that
> didn't you?

They need more polish to do what the commit log claims, i.e. make them
useful for bisection and atm everyone is digging through the [gh]uc init
and loaders. It's a bit busy there atm.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux