Re: [PATCH] drm/i915: Assert that the request->tail is always qword aligned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 17, 2017 at 04:38:33PM +0000, Chris Wilson wrote:
> The hardware requires that the tail pointer only advance in qword units,
> so assert that the value we write is aligned to qwords, and similarly
> enforce this restriction onto the request->tail.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

LGTM.
Quick grep confirms that those are indeed all the relevant spots where we're
updating req->tail.

Reviewed-by: Michał Winiarski <michal.winiarski@xxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/intel_lrc.c        | 4 ++++
>  drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++
>  2 files changed, 7 insertions(+)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux