Hi I've been trying to understand the clocking code and spotted some possible improvements. None of these changes are actually necessary for anything, but IMHO they make the code a little easier to read and later extend. Feel free to bikeshed or even NAK my proposals. Thanks, Paulo Paulo Zanoni (4): drm/i915: kill {bdw,bxt}_modeset_calc_cdclk drm/i915: add intel_calc_cdclk() drm/i915: remove potentially confusing IS_G4X checks drm/i915: reorganize the get_cdclk assignment drivers/gpu/drm/i915/intel_cdclk.c | 257 ++++++++++++++++--------------------- 1 file changed, 112 insertions(+), 145 deletions(-) -- 2.7.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx