On Wed, Feb 15, 2017 at 02:05:52PM +0000, Tvrtko Ursulin wrote: > +u32 *intel_ring_begin(struct drm_i915_gem_request *req, int num_dwords) > +{ I'd leave this out for the moment (and all the associated ring space) since imo this is a i915_gem_request_emit() (it takes i915_gem_request!). That leaves this patch for moving the workarounds, which seems worthwhile and not too troublesome? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx