On pe, 2017-02-10 at 14:36 +0000, Chris Wilson wrote:
> On Fri, Feb 10, 2017 at 03:30:10PM +0200, Joonas Lahtinen wrote:
> >
> > +static unsigned long __reserve_cacheline(struct intel_guc* guc)
> > {
> > - const uint32_t cacheline_size = cache_line_size();
> > - uint32_t offset;
> > + unsigned long offset;
> >
> > /* Doorbell uses a single cache line within a page */
> > offset = offset_in_page(guc->db_cacheline);
>
> But unsigned long? I was trying to work out why we might need unsigned
> long doorbell_offset, for when the doorbell object is of known size.
>
> That's the only thing that stuck out like a sore thumb.
Fixing that type took me for a too long journey, so I aborted mission.
Added a follow-up task.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
