Re: [PATCH 2/2] drm/i915: Handle validation of relocation object with length >=2GB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 13, 2017 at 12:58:57PM +0200, Joonas Lahtinen wrote:
> On ma, 2017-02-13 at 12:14 +0530, Sagar Arun Kamble wrote:
> > From: "sagar.a.kamble@xxxxxxxxx" <sagar.a.kamble@xxxxxxxxx>
> > 
> > With prefaulting extended to support >=2GB, i915 can handle
> > relocation objects >=2GB. type conversion of length from int to
> > unsigned long in access_ok was making the validation bail out with
> > -EFAULT.
> > 
> > Testcase: igt/gem_exec_reloc/wc-31
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>
> 
> With the correct "From:" and with "size_t" as type, this is;
> 
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

My earlier comments still apply in that this is not how I fixed this
years ago, and I still much prefer my fix.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux