Re: [PATCH 1/2] mm: Handle prefault for size >= 2GB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On ma, 2017-02-13 at 12:14 +0530, Sagar Arun Kamble wrote:
> From: "sagar.a.kamble@xxxxxxxxx" <sagar.a.kamble@xxxxxxxxx>

https://kernel.org/doc/html/latest/process/submitting-patches.html#the-
canonical-patch-format

# git config --global user.name "Sagar Arun Kamble"

> i915 gem_exec_reloc subtests *-31 exercise relocation entries object
> that is of size >=2GB. This patch will allow prefaulting >=2GB size.
> 
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>

<SNIP>

> @@ -538,7 +538,8 @@ static inline void wait_on_page_writeback(struct page *page)
>  /*
>   * Fault everything in given userspace address range in.
>   */
> -static inline int fault_in_pages_writeable(char __user *uaddr, int size)
> +static inline int fault_in_pages_writeable(char __user *uaddr,
> +					   unsigned long size)
>  {
>  	char __user *end = uaddr + size - 1;

ptrdiff_t would be more appropriate for both functions. With those and
correct "From:", this is;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux