Thanks Jani! :P -----Original Message----- From: Jani Nikula [mailto:jani.nikula@xxxxxxxxxxxxxxx] Sent: Thursday, February 9, 2017 8:23 PM To: Wang, Zhi A <zhi.a.wang@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Wang, Zhi A <zhi.a.wang@xxxxxxxxx>; Daniel Vetter <daniel.vetter@xxxxxxxx>; Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>; Winiarski, Michal <michal.winiarski@xxxxxxxxx>; Thierry, Michel <michel.thierry@xxxxxxxxx>; Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>; Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>; Vetter, Daniel <daniel.vetter@xxxxxxxxx>; Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>; Lv, Zhiyuan <zhiyuan.lv@xxxxxxxxx>; drm-intel-fixes@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v3] drm/i915: A hotfix for making aliasing PPGTT work On Thu, 09 Feb 2017, Zhi Wang <zhi.a.wang@xxxxxxxxx> wrote: > This patch makes PPGTT page table non-shrinkable when using aliasing > PPGTT mode. It's just a temporary solution for making aliasing PPGTT mode work. > > v3: > - Fixes the format of "Fixes line". > > v2: > - Add fixes tag. (Chris and Daniel) > > Fixes: 2ce5179fe826 ("drm/i915/gtt: Free unused lower-level page > tables") > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> > Cc: Michal Winiarski <michal.winiarski@xxxxxxxxx> > Cc: Michel Thierry <michel.thierry@xxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx> > Cc: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx> > Cc: Zhiyuan Lv <zhiyuan.lv@xxxxxxxxx> > Signed-off-by: Zhi Wang <zhi.a.wang@xxxxxxxxx> > Link: > http://patchwork.freedesktop.org/patch/msgid/1486559013-25251-2-git-se > nd-email-zhi.a.wang@xxxxxxxxx > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: <drm-intel-fixes@xxxxxxxxxxxxxxxxxxxxx> # v4.10-rc1+ This won't make it to v4.10, as I've sent the pull request already and I anticipate release this Sunday. Whoever applies this needs to add Cc: stable@xxxxxxxxxxxxxxx # v4.10 BR, Jani. > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > b/drivers/gpu/drm/i915/i915_gem_gtt.c > index 22b3374..3233f12 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -756,8 +756,10 @@ static bool gen8_ppgtt_clear_pt(struct > i915_address_space *vm, > > bitmap_clear(pt->used_ptes, pte, num_entries); > > - if (bitmap_empty(pt->used_ptes, GEN8_PTES)) > - return true; > + if (USES_FULL_PPGTT(vm->i915)) { > + if (bitmap_empty(pt->used_ptes, GEN8_PTES)) > + return true; > + } > > pt_vaddr = kmap_px(pt); -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
