Hey, Op 09-02-17 om 10:59 schreef Tomeu Vizoso: > Patch looks good to me, but I think the signal changes should be in > their own commit. > > On 7 February 2017 at 16:12, Maarten Lankhorst > <maarten.lankhorst@xxxxxxxxxxxxxxx> wrote: > ... >> +#define VG(x) x >> +#else >> +#define VG(x) >> +#endif > Wouldn't be better to stub VALGRIND_MAKE_MEM_DEFINED instead? This patch is slightly incomplete, after doing some tests it turns out we need to add a gem_munmap function too, which calls VALGRIND_MAKE_MEM_NOACCESS. I only converted lib/ to use gem_munmap tests need to be fixed too. So that's 2 at least. ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
